Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract playlists description #1061

Merged
merged 6 commits into from
May 17, 2023
Merged

Extract playlists description #1061

merged 6 commits into from
May 17, 2023

Conversation

ChunkyProgrammer
Copy link
Contributor

@ChunkyProgrammer ChunkyProgrammer commented May 11, 2023 •
edited by TobiGr
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

This PR adds a getDescription method for playlist extraction + tests for the description. I am not planning on creating a PR in NewPipe to support this (I implemented this to hopefully add this to the Piped API)

API changes

This PR adds

  • PlaylistExtractor.getDescription() and the corresponding PlaylistInfo.getDescription()
  • PlaylistInfoItemExtractor.getDescription() and the corresponding PlaylistInfoItem.getDescription()

@AudricV AudricV added enhancement youtube service, https://www.youtube.com/ labels May 11, 2023
@TobiGr TobiGr self-assigned this May 11, 2023
AudricV
AudricV previously requested changes May 11, 2023
View reviewed changes
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you need to also implement these changes in PlaylistInfo.

extractor/src/main/java/org/schabi/newpipe/extractor/playlist/PlaylistExtractor.java Show resolved Hide resolved
@AudricV AudricV changed the title [YouTube] Extract playlist description [YouTube] Extract playlists description May 11, 2023
@TobiGr
Copy link
Member

TobiGr commented May 11, 2023

Thanks, you need to also implement these changes in PlaylistInfo.

I already implemented that locally. There are a few more changes which I am going to push within the next days.

@TobiGr
Implement PlaylistInfo.getDescription()
b218bf6 
Implement PlaylistExtractor.getDescription() for PeerTube and SoundCloud.
Anotate   PlaylistExtractor.getDescription() as Nonnull
@TobiGr
Add PlaylistInfoItem.getDescription() and PlaylistInfoItemExtractor.g…
ca0ce00 
…etDescription()

[PeerTube] Implement the corresponding extractor method.
TODO: add tests
@AudricV AudricV changed the title [YouTube] Extract playlists description Extract playlists description May 12, 2023
@AudricV AudricV added multiservice Issues related to multiple services and removed youtube service, https://www.youtube.com/ labels May 12, 2023
@TobiGr TobiGr mentioned this pull request May 12, 2023
Merged
2 tasks
@TobiGr
Copy link
Member

TobiGr commented May 12, 2023

@fynngodau I am unsure which parts of the album description should be used as description. Can you give me an advice?
My current plan is to add .tralbum-about, .tralbum-credits and #license.

@AudricV AudricV dismissed their stale review May 14, 2023 09:32

Outdated review

@TobiGr TobiGr merged commit 3c036a9 into TeamNewPipe:dev May 17, 2023
@AudricV
Copy link
Member

AudricV commented May 18, 2023

I am unsure which parts of the album description should be used as description.

When looking at the website, Bandcamp seems to unify everything you added, but on the mobile Android app, credits are separated in a credits section and the copyright does not appear.

I think we should follow this behavior, as credits and copyright are not parts of a description.

@fynngodau
Copy link
Member

The copyright text is debatable because the individual tracks also always have copyright info, so it is not strictly necessary here and could be removed. The credits otoh should be read out here, as long as there's no separate method getCredits.

@ChunkyProgrammer ChunkyProgrammer deleted the develop/extract-yt-playlist-descrption branch July 3, 2023 22:10
This was referenced Jul 31, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

@FireMasterK FireMasterK FireMasterK approved these changes

@AudricV AudricV AudricV left review comments

Assignees
No one assigned
Labels
enhancement multiservice Issues related to multiple services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChunkyProgrammer @TobiGr @AudricV @fynngodau @FireMasterK